docs: add documentation for ADMIN ALTER DDL JOBS command by tangenta · Pull Request #19085 · pingcap/docs-cn

tangenta · 2024-11-15T03:23:13Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): Support dynamic change to DDL job configuration tidb#57229, tidb: add description for var tidb_ddl_reorg_max_write_speed #19071

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

fzzf678

rest LGTM

ti-chi-bot · 2024-11-15T03:49:56Z

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

… in ADMIN ALTER DDL JOBS documentation

hfxsd · 2024-11-18T09:35:09Z

+- `ADD INDEX`: 
+    - `THREAD`: 并发度，初始值由系统变量 `tidb_ddl_reorg_worker_cnt` 设置。
+    - `BATCH_SIZE`: 批大小，初始值由系统变量 [`tidb_ddl_reorg_batch_size`](/system-variables.md#tidb_ddl_reorg_batch_size) 设置。
+    - `MAX_WRITE_SPEED`: 向每个 TiKV 导入索引记录时的最大带宽限制，初始值由系统变量 [`tidb_ddl_reorg_max_write_speed`](/system-variables.md#tidb_ddl_reorg_max_write_speed-从-v850-版本开始引入) 设置。


For reviewer: 变量 tidb_ddl_reorg_max_write_speed 在这个 PR 中：pingcap/docs#19445

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

Frank945946 · 2024-11-29T12:55:30Z

 ### `ADMIN SHOW DDL JOBS`

-`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近十条结果。该语句的返回结果字段描述如下：
+`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近的结果。该语句的返回结果字段描述如下：


https://docs.pingcap.com/zh/tidb/v8.4/sql-statement-admin-show-ddl#admin-show-ddl-jobs
这个文档里还写着是最近的 10 条，是在 v8.5 修改掉了？
@tangenta

它会取正在运行的十条（如果有）+历史的十条，这里的描述不太准确所以删掉了

那感觉还是你这个最新的解释更加准确清晰。

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

Frank945946 · 2024-12-02T02:21:14Z

 ### `ADMIN SHOW DDL JOBS`

-`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近十条结果。该语句的返回结果字段描述如下：
+`ADMIN SHOW DDL JOBS` 语句用于查看当前 DDL 作业队列中的所有结果（包括正在运行以及等待运行的任务）以及已执行完成的 DDL 作业队列中的最近的结果。该语句的返回结果字段描述如下：


那感觉还是你这个最新的解释更加准确清晰。

ti-chi-bot · 2024-12-02T02:30:20Z

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

lilin90

/lgtm

ti-chi-bot · 2024-12-02T06:52:21Z

[LGTM Timeline notifier]

Timeline:

2024-12-02 06:28:26.14564428 +0000 UTC m=+1049893.765298796: ☑️ agreed by lilin90.
2024-12-02 06:52:20.258845059 +0000 UTC m=+1051327.878499574: ☑️ agreed by hfxsd.

hfxsd · 2024-12-02T07:06:12Z

/approve

ti-chi-bot · 2024-12-02T07:06:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hfxsd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-02T07:10:50Z

In response to a cherrypick label: new pull request created to branch release-8.5: #19185.

…9185)

docs: add documentation for ADMIN ALTER DDL JOBS command

8b32418

ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024

hfxsd self-assigned this Nov 15, 2024

hfxsd added v8.5 translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 15, 2024

hfxsd self-requested a review November 15, 2024 03:29

fzzf678 approved these changes Nov 15, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

hfxsd and others added 4 commits November 15, 2024 14:26

Update sql-statement-admin-alter-ddl.md

db58424

Update sql-statements/sql-statement-admin-alter-ddl.md

8ba0b7e

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

Update sql-statements/sql-statement-admin-alter-ddl.md

ee66331

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

docs: clarify parameter value range consistency with system variables…

3187695

… in ADMIN ALTER DDL JOBS documentation

hfxsd requested a review from lilin90 November 15, 2024 06:40

hfxsd reviewed Nov 18, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

hfxsd reviewed Nov 18, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Update sql-statements/sql-statement-admin-alter-ddl.md

c91a9da

hfxsd reviewed Nov 18, 2024

View reviewed changes

fzzf678 reviewed Nov 20, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md

tangenta and others added 2 commits November 20, 2024 15:37

Update sql-statements/sql-statement-admin-alter-ddl.md

540be02

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

update admin show ddl jobs doc

32ad9c1

ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2024

Update TOC.md

6d99637

hfxsd reviewed Nov 22, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

tangenta mentioned this pull request Nov 22, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command pingcap/docs#19492

Merged

17 tasks

fzzf678 reviewed Nov 22, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

hfxsd reviewed Nov 25, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

hfxsd removed the translation/doing This PR’s assignee is translating this PR. label Nov 25, 2024

Frank945946 reviewed Nov 29, 2024

View reviewed changes

Update sql-statements/sql-statement-admin-show-ddl.md

81762e9

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

tangenta commented Nov 30, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md Outdated

Update sql-statements/sql-statement-admin-alter-ddl.md

004e915

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

Apply suggestions from code review

7d1ba51

Frank945946 approved these changes Dec 2, 2024

View reviewed changes

Apply suggestions from code review

3aecf54

Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>

lilin90 reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-show-ddl.md Outdated

lilin90 added 2 commits December 2, 2024 13:45

Apply suggestions from code review

ecc162e

Update format

899c438

hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 2, 2024

lilin90 approved these changes Dec 2, 2024

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024

hfxsd approved these changes Dec 2, 2024

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024

hfxsd reviewed Dec 2, 2024

View reviewed changes

Comment thread sql-statements/sql-statement-admin-alter-ddl.md

Update sql-statements/sql-statement-admin-alter-ddl.md

546eaed

ti-chi-bot mentioned this pull request Dec 2, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command (#19492) pingcap/docs#19546

Merged

17 tasks

ti-chi-bot Bot added the approved label Dec 2, 2024

ti-chi-bot Bot merged commit 76f6555 into pingcap:master Dec 2, 2024

ti-chi-bot mentioned this pull request Dec 2, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command (#19085) #19185

Merged

17 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Dec 2, 2024

docs: add documentation for ADMIN ALTER DDL JOBS command (#19085) (#1…

c51255c

…9185)

Conversation

tangenta commented Nov 15, 2024 • edited by hfxsd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

fzzf678 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Nov 15, 2024

Uh oh!

Uh oh!

Uh oh!

hfxsd Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frank945946 Nov 29, 2024

Choose a reason for hiding this comment

Uh oh!

tangenta Nov 30, 2024

Choose a reason for hiding this comment

Uh oh!

Frank945946 Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Frank945946 Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

[LGTM Timeline notifier]

Uh oh!

Uh oh!

hfxsd commented Dec 2, 2024

Uh oh!

ti-chi-bot Bot commented Dec 2, 2024

Uh oh!

ti-chi-bot commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tangenta commented Nov 15, 2024 •

edited by hfxsd

Loading

hfxsd Nov 18, 2024 •

edited

Loading